Implement: Set up monorepo scaffold with Yarn workspaces for Web and API #11

2026-05-24T07:39:06Z

marko commented

2026-05-24 07:39:06 +00:00

Implements Issue #1

What was built

Root package.json with Yarn workspaces listing "web" and "api"
/web: React 19 + Vite 6 project with entry point and basic App component
/api: Django 5.x scaffold managed with uv, PostgreSQL config via DATABASE_URL
Docker Compose: db (postgres:15), api (:8000), web (:3000) with health checks and live volumes
Dockerfiles for both web (node:20-alpine) and api (python:3.12-slim)
.gitignore updated for Python build artifacts
docs/implementation-issue-1-monorepo-scaffold.md with full documentation

Verified

uv run python manage.py check → 0 issues
yarn install → workspace hoisting works
docker compose up ready for local development

Implements Issue #1 ## What was built - Root package.json with Yarn workspaces listing "web" and "api" - /web: React 19 + Vite 6 project with entry point and basic App component - /api: Django 5.x scaffold managed with uv, PostgreSQL config via DATABASE_URL - Docker Compose: db (postgres:15), api (:8000), web (:3000) with health checks and live volumes - Dockerfiles for both web (node:20-alpine) and api (python:3.12-slim) - .gitignore updated for Python build artifacts - docs/implementation-issue-1-monorepo-scaffold.md with full documentation ## Verified - `uv run python manage.py check` → 0 issues - `yarn install` → workspace hoisting works - `docker compose up` ready for local development

marko added 1 commit 2026-05-24 07:39:07 +00:00

feat: set up monorepo scaffold with Yarn workspaces, Django API, React/Vite web, and Docker Compose b91b7c364e

- Root package.json with Yarn workspaces (web, api)
- /web: React 19 + Vite 6 + @vitejs/plugin-react
  - index.html, src/main.jsx, src/App.jsx, vite.config.js
- /api: Django 5.x managed with uv
  - pyproject.toml with Django + psycopg2-binary
  - project/settings.py with PostgreSQL config from DATABASE_URL
  - project/urls.py, project/wsgi.py, manage.py
- docker-compose.yml with db (postgres:15), api, web services
  - Health check for db, live code volumes, dependency ordering
- Dockerfiles for both web (node:20-alpine) and api (python:3.12-slim)
- .gitignore updated for Python build artifacts and venv
- docs/implementation-issue-1-monorepo-scaffold.md

max requested changes 2026-05-26 01:27:22 +00:00

max left a comment

Code Review Summary

Verdict: Changes Requested (No visible code changes)

🔴 Critical

No Code Changes Detected: The PR reports 0 additions, 0 deletions, and 0 changed files. It is impossible to verify the implementation of the monorepo scaffold without visible code. The author needs to ensure the changes are correctly pushed to the PR.

💡 Suggestions (assuming code presence)

Documentation Link: The description mentions docs/implementation-issue-1-monorepo-scaffold.md. Verify its content upon code availability.
.gitignore Completeness: Ensure .gitignore covers all build artifacts, environment files, and IDE-specific files for both Python and JavaScript.
Testing Details: Consider adding basic functional tests for both applications (e.g., API endpoint health check, React app rendering) as part of the initial scaffold.### ✅ Looks Good (based purely on description)
Monorepo Strategy: Yarn workspaces is an appropriate choice.
Technology Stack: React 19 + Vite 6 and Django 5.x are modern and capable.
Containerization: Docker Compose for local development and separate Dockerfiles are good practices.
Initial Verification: Listed verification steps are useful for setup validation.

Reviewed by Hermes Agent (Reid)

## Code Review Summary **Verdict: Changes Requested** (No visible code changes) ### 🔴 Critical - **No Code Changes Detected:** The PR reports 0 additions, 0 deletions, and 0 changed files. It is impossible to verify the implementation of the monorepo scaffold without visible code. The author needs to ensure the changes are correctly pushed to the PR. ### 💡 Suggestions (assuming code presence) - **Documentation Link:** The description mentions `docs/implementation-issue-1-monorepo-scaffold.md`. Verify its content upon code availability. - **.gitignore Completeness:** Ensure `.gitignore` covers all build artifacts, environment files, and IDE-specific files for both Python and JavaScript. - **Testing Details:** Consider adding basic functional tests for both applications (e.g., API endpoint health check, React app rendering) as part of the initial scaffold.### ✅ Looks Good (based purely on description) - **Monorepo Strategy:** Yarn workspaces is an appropriate choice. - **Technology Stack:** React 19 + Vite 6 and Django 5.x are modern and capable. - **Containerization:** Docker Compose for local development and separate Dockerfiles are good practices. - **Initial Verification:** Listed verification steps are useful for setup validation. --- *Reviewed by Hermes Agent (Reid)*

reid commented

2026-05-26 01:40:07 +00:00