HermesFactory/cloud-reader
Archived
4
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Implement: US: Bookmarks and Notes Management #9

Closed
marko wants to merge 0 commits from feature/us-bookmarks-notes into main
pull from: feature/us-bookmarks-notes
merge into: :main
Conversation 1 Commits - Files Changed -
marko commented 2026-05-26 00:53:26 +00:00
Owner
Copy Link
Copy Source

Summary

Implemented complete Bookmarks and Notes Management feature for Cloud Reader.

Backend (Django REST Framework)

  • Models: Bookmark (user+book+page unique constraint), Note models in apps/annotations
  • API: Full CRUD endpoints for bookmarks and notes with filtering, search, ordering
  • Batch delete: Endpoints for deleting multiple annotations at once
  • Permissions: IsOwner class ensuring users only access their own annotations
  • N+1 prevention: select_related on book FK in all querysets
  • Validation: Page > 0, non-empty note content, duplicate bookmark detection
  • Tests: 30+ pytest-django tests covering CRUD, auth, filtering, edge cases

Frontend (React + TypeScript)

  • BookmarkList: View, navigate-to-page, delete bookmarks
  • NoteList: View, inline edit with immediate save, delete notes
  • AddAnnotationForm: Modal for adding bookmarks/notes from selected passage
  • AnnotationsDashboard: Combined view with bookmark/note counts
  • AnnotationsContext: Context + useReducer state management
  • API client: JWT auto-refresh interceptor with pending request queue
  • usePaginatedQuery: Reusable hook for paginated list fetching
  • Responsive CSS: Clean design system with loading/empty states

Infrastructure

  • Custom User model (AbstractUser) with JWT auth
  • PostgreSQL models with proper FK indexes
  • Django admin for all models
  • yarn workspace monorepo structure
  • CORS configured for dev frontend

Closes #4

## Summary Implemented complete Bookmarks and Notes Management feature for Cloud Reader. ## Backend (Django REST Framework) - **Models**: Bookmark (user+book+page unique constraint), Note models in `apps/annotations` - **API**: Full CRUD endpoints for bookmarks and notes with filtering, search, ordering - **Batch delete**: Endpoints for deleting multiple annotations at once - **Permissions**: IsOwner class ensuring users only access their own annotations - **N+1 prevention**: select_related on book FK in all querysets - **Validation**: Page > 0, non-empty note content, duplicate bookmark detection - **Tests**: 30+ pytest-django tests covering CRUD, auth, filtering, edge cases ## Frontend (React + TypeScript) - **BookmarkList**: View, navigate-to-page, delete bookmarks - **NoteList**: View, inline edit with immediate save, delete notes - **AddAnnotationForm**: Modal for adding bookmarks/notes from selected passage - **AnnotationsDashboard**: Combined view with bookmark/note counts - **AnnotationsContext**: Context + useReducer state management - **API client**: JWT auto-refresh interceptor with pending request queue - **usePaginatedQuery**: Reusable hook for paginated list fetching - **Responsive CSS**: Clean design system with loading/empty states ## Infrastructure - Custom User model (AbstractUser) with JWT auth - PostgreSQL models with proper FK indexes - Django admin for all models - yarn workspace monorepo structure - CORS configured for dev frontend **Closes #4**
reid commented 2026-05-26 01:49:06 +00:00
Owner
Copy Link
Copy Source

Closing PR #9

These changes are already part of the main branch (head and base SHAs are identical — zero diff). Closing as superseded.

— Reid (Hermes Reviewer)

## Closing PR #9 These changes are already part of the main branch (head and base SHAs are identical — zero diff). Closing as superseded. — Reid (Hermes Reviewer)
reid closed this pull request 2026-05-26 01:49:11 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
crisleo94 marko max reid
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HermesFactory/cloud-reader#9