Feature/uv implementation #26

2026-06-04T04:03:31Z

crisleo94 commented

2026-06-04 04:03:31 +00:00

No description provided.

crisleo94 added 5 commits 2026-06-04 04:03:31 +00:00

feat: uv config other feats 6b4c0c43f8

- add uv configuration for the backend
- update frontend to make auth work
- add new auth endpoints
- add bookmars feat
- add reader feat

feat: floating bookmarks 054e7689bd

add floating bookmarks

fix: floating bookmarks d9c66e68a6

- update floating bookmarks
- fix search suggestions
- fix filters

feat: pdf reader f091386974

fix: pdf bookmark f989b144cf

for pdfs only select pages not text

reid commented

2026-06-04 04:16:50 +00:00

Reid's Review — PR #26

Verdict: 🔴 Changes Required

🔴 Blocking Issues

These MUST be resolved before this PR can be merged.

[File: .env.example | Line ~2] configuration error
Typo: POSTGRES_DB=postres should be POSTGRES_DB=postgres. This will confuse users setting up the project.
[File: .gitignore | Lines ~6-15] missing ignore pattern
Binary media files are being committed (books/media/ebooks/*.epub, .pdf, media/ebook_covers/.jpg). The .gitignore should include backend/media/ or at minimum backend/media/ebooks/ and backend/media/ebook_covers/ to prevent committing user-uploaded content and generated cover images.
[File: backend/apps/books/serializers.py | Line ~49] missing type hint
get_progress method in EBookListSerializer is missing return type annotation. Should return dict[str, Any] | None based on the return values.
[File: backend/apps/books/serializers.py | Line ~98] missing type hint
get_started method in EBookListSerializer is missing return type annotation. Should return bool.
[File: backend/apps/books/serializers.py | Line ~137] missing type hint
validate_current_position in ReadingProgressSerializer is missing return type annotation. Should return float.
[File: backend/apps/books/serializers.py | Line ~151] missing type hint
get_progress method in EBookDetailSerializer is missing return type annotation.

🟡 Suggestions (Non-Blocking)

These are recommendations for improvement. Not required for merge.

[File: backend/.env.example] Consider aligning with the root .env.example format or clarifying which one is the source of truth. Having two example env files could confuse developers.
[File: backend/apps/annotations/models.py | Line ~112] Note.__str__ could truncate self.content more defensively (handle None case).
[File: backend/apps/annotations/views.py | Line ~52] BookmarkViewSet.get_queryset may benefit from prefetch_related if markers are frequently accessed with annotations.
[File: docs/backend/010-open-library-metadata.md] The spec mentions no migration needed, but the implementation adds epub_location to ReadingProgress - ensure this is documented correctly or the migration is properly included.

📋 AC Coverage

Based on linked issue

No linked issue found. Review based on code quality standards only.

## Reid's Review — PR #26 **Verdict:** 🔴 Changes Required --- ### 🔴 Blocking Issues > These MUST be resolved before this PR can be merged. - **[File: .env.example | Line ~2]** `configuration error` Typo: `POSTGRES_DB=postres` should be `POSTGRES_DB=postgres`. This will confuse users setting up the project. - **[File: .gitignore | Lines ~6-15]** `missing ignore pattern` Binary media files are being committed (books/media/ebooks/*.epub, *.pdf, media/ebook_covers/*.jpg). The .gitignore should include `backend/media/` or at minimum `backend/media/ebooks/` and `backend/media/ebook_covers/` to prevent committing user-uploaded content and generated cover images. - **[File: backend/apps/books/serializers.py | Line ~49]** `missing type hint` `get_progress` method in `EBookListSerializer` is missing return type annotation. Should return `dict[str, Any] | None` based on the return values. - **[File: backend/apps/books/serializers.py | Line ~98]** `missing type hint` `get_started` method in `EBookListSerializer` is missing return type annotation. Should return `bool`. - **[File: backend/apps/books/serializers.py | Line ~137]** `missing type hint` `validate_current_position` in `ReadingProgressSerializer` is missing return type annotation. Should return `float`. - **[File: backend/apps/books/serializers.py | Line ~151]** `missing type hint` `get_progress` method in `EBookDetailSerializer` is missing return type annotation. --- ### 🟡 Suggestions (Non-Blocking) > These are recommendations for improvement. Not required for merge. - **[File: backend/.env.example]** Consider aligning with the root `.env.example` format or clarifying which one is the source of truth. Having two example env files could confuse developers. - **[File: backend/apps/annotations/models.py | Line ~112]** `Note.__str__` could truncate `self.content` more defensively (handle None case). - **[File: backend/apps/annotations/views.py | Line ~52]** `BookmarkViewSet.get_queryset` may benefit from `prefetch_related` if markers are frequently accessed with annotations. - **[File: docs/backend/010-open-library-metadata.md]** The spec mentions no migration needed, but the implementation adds `epub_location` to `ReadingProgress` - ensure this is documented correctly or the migration is properly included. --- ### 📋 AC Coverage > Based on linked issue No linked issue found. Review based on code quality standards only.

crisleo94 added 2 commits 2026-06-04 11:45:50 +00:00

fix: cleanup 654cfec147

fix: remove binary files 724eae1142

crisleo94 merged commit 84c0497f21 into main

2026-06-04 12:10:52 +00:00

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: HermesFactory/cloud-reader#26