9 changed files with 3 additions and 1169 deletions
-117
View File
@@ -1,117 +0,0 @@
# Trello Plugin — Manage Trello Boards
**Feature:** US: Manage Trello Boards
**Issue:** #2
**Branch:** `feature/manage-boards`
**Doc:** 002
## Overview
Extends the Trello plugin with board management capabilities: create, rename, close/archive, open, and view details of Trello boards.
## Design Decisions
- **Extends existing TrelloClient** — All board operations go through the same `TrelloClient` class from the auth feature.
- **Board selection by ID** — The Trello API identifies boards by ID. The tool accepts both ID and name (client resolves name to ID).
- **Resolves board name to ID** — When a user provides a board name instead of ID, the client fetches all boards and matches by name.
## Tools
### `trello_create_board`
Create a new Trello board.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `name` | string | Yes | Board name |
| `default_lists` | bool | No | Whether to create the default lists (default: true) |
**Returns:**
```json
{
"success": true,
"board": {"id": "abc123", "name": "My Board", "url": "https://trello.com/b/abc123"}
}
```
### `trello_rename_board`
Rename an existing board.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `board_id` | string | Yes | Board ID or name |
| `name` | string | Yes | New board name |
**Returns:**
```json
{"success": true, "board": {"id": "abc123", "name": "New Name"}}
```
### `trello_archive_board`
Close/archive a board.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `board_id` | string | Yes | Board ID or name |
**Returns:**
```json
{"success": true, "message": "Board 'My Board' archived."}
```
### `trello_open_board`
Re-open a closed/archived board.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `board_id` | string | Yes | Board ID or name |
**Returns:**
```json
{"success": true, "message": "Board 'My Board' opened."}
```
### `trello_board_details`
View details of a specific board, including its lists and members.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `board_id` | string | Yes | Board ID or name |
**Returns:**
```json
{
"success": true,
"board": {
"id": "abc123",
"name": "My Board",
"url": "https://trello.com/b/abc123",
"desc": "",
"closed": false,
"starred": false,
"lists": [{"id": "l1", "name": "To Do"}, {"id": "l2", "name": "In Progress"}],
"members": [{"id": "m1", "username": "user1", "full_name": "User One"}]
}
}
```
## Trello API Endpoints
| Purpose | Method | Endpoint |
|---------|--------|----------|
| Create board | POST | `/1/boards/` |
| Update board | PUT | `/1/boards/{id}` |
| Get board details | GET | `/1/boards/{id}` (with lists and members fields) |
## Error Handling
- Board not found → clear message suggesting `trello_list_boards` to find the ID
- Validation errors → surfaced directly from Trello API
-89
View File
@@ -1,89 +0,0 @@
# Trello Plugin — Manage Trello Lists
**Feature:** US: Manage Trello Lists
**Issue:** #3
**Branch:** `feature/manage-lists`
**Doc:** 003
## Overview
Extends the Trello plugin with list management capabilities: create, rename, archive, and reposition lists on a Trello board.
## Design Decisions
- **Lists require a board context** — Creating a list needs a board ID. Other operations (rename, archive, move) use the list's Trello ID which is globally unique.
- **Position parameter** — Uses Trello's `pos` field which accepts `"top"`, `"bottom"`, or a positive number.
## Tools
### `trello_create_list`
Create a new list on a board.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `name` | string | Yes | List name |
| `board_id` | string | Yes | Board ID or name |
| `pos` | string | No | Position: `"top"`, `"bottom"`, or number (default: `"bottom"`) |
**Returns:**
```json
{"success": true, "list": {"id": "l1", "name": "My List", "id_board": "b1"}}
```
### `trello_rename_list`
Rename an existing list.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `list_id` | string | Yes | List ID |
| `name` | string | Yes | New name |
**Returns:**
```json
{"success": true, "list": {"id": "l1", "name": "Renamed List"}}
```
### `trello_archive_list`
Archive a list.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `list_id` | string | Yes | List ID |
**Returns:**
```json
{"success": true, "message": "List 'My List' archived."}
```
### `trello_move_list`
Move a list to a different position.
**Parameters:**
| Param | Type | Required | Description |
|-------|------|----------|-------------|
| `list_id` | string | Yes | List ID |
| `pos` | string | Yes | Position: `"top"`, `"bottom"`, or a number |
**Returns:**
```json
{"success": true, "message": "List 'My List' moved."}
```
## Trello API Endpoints
| Purpose | Method | Endpoint |
|---------|--------|----------|
| Create list | POST | `/1/lists` |
| Update list (rename, archive, move) | PUT | `/1/lists/{id}` |
## Error Handling
- List not found → clear error message
- Board not found when creating → propagate board lookup error
@@ -3,7 +3,6 @@
**Feature:** US: Authenticate and Connect to Trello Account **Feature:** US: Authenticate and Connect to Trello Account
**Issue:** #1 **Issue:** #1
**Branch:** `feature/trello-auth` **Branch:** `feature/trello-auth`
**Doc:** 001
## Overview ## Overview
@@ -65,9 +64,7 @@ Fetches and returns all Trello boards accessible to the authenticated user.
### 3. `trello_disconnect` ### 3. `trello_disconnect`
Clears the stored credentials from memory. Since credentials are stored in environment variables, the next tool call will automatically re-read them and reconnect. To fully disconnect, also unset ``TRELLO_API_KEY`` and ``TRELLO_TOKEN`` from the Hermes profile config. Clears the stored credentials from memory. Note: this does not revoke the Trello token — the user must invalidate it via Trello's settings if needed.
Note: this does NOT revoke the Trello token — the user must invalidate it via Trello's settings if needed.
**Parameters:** None **Parameters:** None
@@ -75,7 +72,7 @@ Note: this does NOT revoke the Trello token — the user must invalidate it via
```json ```json
{ {
"success": true, "success": true,
"message": "Trello credentials cleared from memory. Next tool call will re-read TRELLO_API_KEY and TRELLO_TOKEN from environment and reconnect automatically." "message": "Trello credentials cleared. Set TRELLO_API_KEY and TRELLO_TOKEN again to reconnect."
} }
``` ```
@@ -85,9 +82,6 @@ Note: this does NOT revoke the Trello token — the user must invalidate it via
```python ```python
class TrelloClient: class TrelloClient:
api_key: str
token: str
def __init__(self, api_key: str | None = None, token: str | None = None) def __init__(self, api_key: str | None = None, token: str | None = None)
def verify_credentials(self) -> dict def verify_credentials(self) -> dict
@@ -95,8 +89,6 @@ class TrelloClient:
def disconnect(self) -> dict def disconnect(self) -> dict
``` ```
The client uses `TypedDict` response contracts (`SuccessResponse`/`ErrorResponse`) with a `TypeGuard` helper `_is_success()` for type-safe narrowing. Internal helpers include `_request()`, `_get()`, `_post()`, `_put()`, `_check_credentials()`, and `_handle_http_error()`.
### Trello API Endpoints Used ### Trello API Endpoints Used
| Purpose | Method | Endpoint | Docs | | Purpose | Method | Endpoint | Docs |
-18
View File
@@ -8,17 +8,8 @@ from trello_plugin.tools import (
PLUGIN_TOOLS, PLUGIN_TOOLS,
PLUGIN_VERSION, PLUGIN_VERSION,
check_requirements, check_requirements,
trello_archive_board,
trello_archive_list,
trello_board_details,
trello_create_board,
trello_create_list,
trello_disconnect, trello_disconnect,
trello_list_boards, trello_list_boards,
trello_move_list,
trello_open_board,
trello_rename_board,
trello_rename_list,
trello_verify_credentials, trello_verify_credentials,
) )
@@ -31,13 +22,4 @@ __all__ = [
"trello_verify_credentials", "trello_verify_credentials",
"trello_list_boards", "trello_list_boards",
"trello_disconnect", "trello_disconnect",
"trello_create_board",
"trello_rename_board",
"trello_archive_board",
"trello_open_board",
"trello_board_details",
"trello_create_list",
"trello_rename_list",
"trello_archive_list",
"trello_move_list",
] ]
-109
View File
@@ -259,11 +259,6 @@ class TrelloClient:
board = result["data"] board = result["data"]
return {"id": board["id"], "name": board.get("name", ""), "url": board.get("url", "")} return {"id": board["id"], "name": board.get("name", ""), "url": board.get("url", "")}
# If the error is about missing credentials, propagate that directly
error_msg = result.get("message", "")
if "TRELLO_API_KEY" in error_msg:
return {"success": False, "message": error_msg}
# Try resolving by name # Try resolving by name
boards_result = self.list_boards() boards_result = self.list_boards()
if not _is_success(boards_result): # type: ignore[arg-type] if not _is_success(boards_result): # type: ignore[arg-type]
@@ -467,110 +462,6 @@ class TrelloClient:
}, },
} }
# ------------------------------------------------------------------
# Public API — List Management
# ------------------------------------------------------------------
def create_list(self, name: str, board_id: str, pos: str = "bottom") -> dict[str, Any]:
"""Create a new list on a Trello board.
Args:
name: The name for the new list.
board_id: Board ID or name.
pos: Position — ``"top"``, ``"bottom"``, or a number.
Returns:
dict with list details on success, or an error dict.
"""
resolved = self._resolve_board_id(board_id)
if "success" in resolved and resolved["success"] is False:
return resolved # type: ignore[typeddict-item]
body: dict[str, Any] = {
"name": name,
"idBoard": resolved["id"],
"pos": pos,
}
result = self._post("/lists", json_body=body)
if _is_success(result):
lst = result["data"]
return {
"success": True,
"list": {
"id": lst.get("id"),
"name": lst.get("name"),
"id_board": lst.get("idBoard"),
},
}
return {
"success": False,
"message": result.get("message", "Failed to create list."),
}
def rename_list(self, list_id: str, name: str) -> dict[str, Any]:
"""Rename an existing list.
Args:
list_id: Trello list ID.
name: The new name.
Returns:
dict with list details on success, or an error dict.
"""
result = self._put(f"/lists/{list_id}", json_body={"name": name})
if _is_success(result):
lst = result["data"]
return {
"success": True,
"list": {
"id": lst.get("id"),
"name": lst.get("name"),
},
}
return {
"success": False,
"message": result.get("message", "Failed to rename list."),
}
def archive_list(self, list_id: str) -> dict[str, Any]:
"""Archive a list.
Args:
list_id: Trello list ID.
Returns:
dict with success message or error.
"""
result = self._put(f"/lists/{list_id}", json_body={"closed": True})
if _is_success(result):
lst = result["data"]
list_name = lst.get("name", list_id)
return {"success": True, "message": f"List '{list_name}' archived."}
return {
"success": False,
"message": result.get("message", "Failed to archive list."),
}
def move_list(self, list_id: str, pos: str = "bottom") -> dict[str, Any]:
"""Move a list to a different position on the board.
Args:
list_id: Trello list ID.
pos: Position — ``"top"``, ``"bottom"``, or a number.
Returns:
dict with success message or error.
"""
result = self._put(f"/lists/{list_id}", json_body={"pos": pos})
if _is_success(result):
lst = result["data"]
list_name = lst.get("name", list_id)
return {"success": True, "message": f"List '{list_name}' moved."}
return {
"success": False,
"message": result.get("message", "Failed to move list."),
}
@staticmethod @staticmethod
def check_requirements() -> bool: def check_requirements() -> bool:
"""Check if the required environment variables are set.""" """Check if the required environment variables are set."""
-193
View File
@@ -76,190 +76,6 @@ def trello_disconnect() -> str:
return _respond({"success": True, "message": "Trello credentials cleared from memory. Next tool call will re-read TRELLO_API_KEY and TRELLO_TOKEN from environment and reconnect automatically."}) return _respond({"success": True, "message": "Trello credentials cleared from memory. Next tool call will re-read TRELLO_API_KEY and TRELLO_TOKEN from environment and reconnect automatically."})
# ---------------------------------------------------------------------------
# Tools — Board Management
# ---------------------------------------------------------------------------
def trello_create_board(name: str, default_lists: bool = True) -> str: # noqa: FBT001, FBT002
"""Create a new Trello board.
Parameters
----------
name : str
The name for the new board.
default_lists : bool, optional
Whether to create default lists (default: True).
Returns
-------
str
JSON with board id, name, and URL on success.
"""
client = _get_client()
result = client.create_board(name=name, default_lists=default_lists)
return _respond(result)
def trello_rename_board(board_id: str, name: str) -> str:
"""Rename an existing Trello board.
Parameters
----------
board_id : str
Board ID or name.
name : str
The new name for the board.
Returns
-------
str
JSON with updated board details on success.
"""
client = _get_client()
result = client.rename_board(board_id=board_id, name=name)
return _respond(result)
def trello_archive_board(board_id: str) -> str:
"""Close/archive a Trello board.
Parameters
----------
board_id : str
Board ID or name.
Returns
-------
str
JSON with success message.
"""
client = _get_client()
result = client.archive_board(board_id=board_id)
return _respond(result)
def trello_open_board(board_id: str) -> str:
"""Re-open a closed/archived Trello board.
Parameters
----------
board_id : str
Board ID or name.
Returns
-------
str
JSON with success message.
"""
client = _get_client()
result = client.open_board(board_id=board_id)
return _respond(result)
def trello_board_details(board_id: str) -> str:
"""View details of a Trello board, including its lists and members.
Parameters
----------
board_id : str
Board ID or name.
Returns
-------
str
JSON with board details including lists and members.
"""
client = _get_client()
result = client.board_details(board_id=board_id)
return _respond(result)
# ---------------------------------------------------------------------------
# Tools — List Management
# ---------------------------------------------------------------------------
def trello_create_list(name: str, board_id: str, pos: str = "bottom") -> str:
"""Create a new list on a Trello board.
Parameters
----------
name : str
The name for the new list.
board_id : str
Board ID or name.
pos : str, optional
Position: ``"top"``, ``"bottom"``, or a number (default: ``"bottom"``).
Returns
-------
str
JSON with list details on success.
"""
client = _get_client()
result = client.create_list(name=name, board_id=board_id, pos=pos)
return _respond(result)
def trello_rename_list(list_id: str, name: str) -> str:
"""Rename an existing list.
Parameters
----------
list_id : str
Trello list ID.
name : str
The new name.
Returns
-------
str
JSON with updated list details on success.
"""
client = _get_client()
result = client.rename_list(list_id=list_id, name=name)
return _respond(result)
def trello_archive_list(list_id: str) -> str:
"""Archive a list.
Parameters
----------
list_id : str
Trello list ID.
Returns
-------
str
JSON with success message.
"""
client = _get_client()
result = client.archive_list(list_id=list_id)
return _respond(result)
def trello_move_list(list_id: str, pos: str = "bottom") -> str:
"""Move a list to a different position on the board.
Parameters
----------
list_id : str
Trello list ID.
pos : str, optional
Position: ``"top"``, ``"bottom"``, or a number (default: ``"bottom"``).
Returns
-------
str
JSON with success message.
"""
client = _get_client()
result = client.move_list(list_id=list_id, pos=pos)
return _respond(result)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Plugin metadata (used by Hermes plugin loader) # Plugin metadata (used by Hermes plugin loader)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -271,15 +87,6 @@ PLUGIN_TOOLS = [
trello_verify_credentials, trello_verify_credentials,
trello_list_boards, trello_list_boards,
trello_disconnect, trello_disconnect,
trello_create_board,
trello_rename_board,
trello_archive_board,
trello_open_board,
trello_board_details,
trello_create_list,
trello_rename_list,
trello_archive_list,
trello_move_list,
] ]
PLUGIN_REQUIRES_ENV = ["TRELLO_API_KEY", "TRELLO_TOKEN"] PLUGIN_REQUIRES_ENV = ["TRELLO_API_KEY", "TRELLO_TOKEN"]
+1 -1
View File
@@ -325,5 +325,5 @@ class TestPluginMetadata:
assert PLUGIN_NAME == "trello-plugin" assert PLUGIN_NAME == "trello-plugin"
assert isinstance(PLUGIN_DESCRIPTION, str) assert isinstance(PLUGIN_DESCRIPTION, str)
assert isinstance(PLUGIN_VERSION, str) assert isinstance(PLUGIN_VERSION, str)
assert len(PLUGIN_TOOLS) == 12 assert len(PLUGIN_TOOLS) == 3
assert all(callable(t) for t in PLUGIN_TOOLS) assert all(callable(t) for t in PLUGIN_TOOLS)
-406
View File
@@ -1,406 +0,0 @@
"""Tests for the Trello plugin — board management feature."""
from __future__ import annotations
import json
import os
from typing import Any
import pytest
import requests
pytestmark = pytest.mark.usefixtures("clear_env")
# ---------------------------------------------------------------------------
# Fixtures
# ---------------------------------------------------------------------------
@pytest.fixture(autouse=True)
def clear_env(monkeypatch: pytest.MonkeyPatch) -> Any:
"""Remove Trello env vars before each test so state is predictable."""
monkeypatch.delenv("TRELLO_API_KEY", raising=False)
monkeypatch.delenv("TRELLO_TOKEN", raising=False)
# ---------------------------------------------------------------------------
# TrelloClient — create_board
# ---------------------------------------------------------------------------
class TestCreateBoard:
"""Tests for TrelloClient.create_board()."""
def test_success(self, requests_mock: Any) -> None:
"""Happy path: creates a board and returns details."""
from trello_plugin.client import TrelloClient
requests_mock.post(
"https://api.trello.com/1/boards",
json={"id": "b1", "name": "New Board", "url": "https://trello.com/b/b1"},
status_code=200,
)
client = TrelloClient(api_key="key", token="tok")
result = client.create_board(name="New Board")
assert result["success"] is True
assert result["board"]["name"] == "New Board"
assert result["board"]["id"] == "b1"
def test_missing_credentials(self) -> None:
"""Missing creds returns error before any network call."""
from trello_plugin.client import TrelloClient
client = TrelloClient(api_key="", token="")
result = client.create_board(name="Board")
assert result["success"] is False
assert "TRELLO_API_KEY" in result["message"]
# ---------------------------------------------------------------------------
# TrelloClient — rename_board
# ---------------------------------------------------------------------------
class TestRenameBoard:
"""Tests for TrelloClient.rename_board()."""
def test_success_by_id(self, requests_mock: Any) -> None:
"""Renaming a board by ID works."""
from trello_plugin.client import TrelloClient
# Resolve board
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Old Name", "url": "https://trello.com/b/b1"},
)
# Rename
requests_mock.put(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "New Name", "url": "https://trello.com/b/b1"},
)
client = TrelloClient(api_key="key", token="tok")
result = client.rename_board(board_id="b1", name="New Name")
assert result["success"] is True
assert result["board"]["name"] == "New Name"
def test_board_not_found(self, requests_mock: Any) -> None:
"""Non-existent board returns a clear error."""
from trello_plugin.client import TrelloClient
# Board lookup fails
requests_mock.get(
"https://api.trello.com/1/boards/nonexistent",
status_code=404,
)
# List boards returns empty
requests_mock.get(
"https://api.trello.com/1/members/me/boards",
json=[],
)
client = TrelloClient(api_key="key", token="tok")
result = client.rename_board(board_id="nonexistent", name="New")
assert result["success"] is False
assert "not found" in result["message"].lower()
# ---------------------------------------------------------------------------
# TrelloClient — archive_board
# ---------------------------------------------------------------------------
class TestArchiveBoard:
"""Tests for TrelloClient.archive_board()."""
def test_success(self, requests_mock: Any) -> None:
"""Archiving a board returns success message."""
from trello_plugin.client import TrelloClient
# Resolve
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "url": "https://trello.com/b/b1"},
)
# Archive
requests_mock.put(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "closed": True},
)
client = TrelloClient(api_key="key", token="tok")
result = client.archive_board(board_id="b1")
assert result["success"] is True
assert "archived" in result["message"].lower()
# ---------------------------------------------------------------------------
# TrelloClient — open_board
# ---------------------------------------------------------------------------
class TestOpenBoard:
"""Tests for TrelloClient.open_board()."""
def test_success(self, requests_mock: Any) -> None:
"""Opening a closed board returns success message."""
from trello_plugin.client import TrelloClient
# Resolve
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "url": "https://trello.com/b/b1"},
)
# Open
requests_mock.put(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "closed": False},
)
client = TrelloClient(api_key="key", token="tok")
result = client.open_board(board_id="b1")
assert result["success"] is True
assert "opened" in result["message"].lower()
# ---------------------------------------------------------------------------
# TrelloClient — board_details
# ---------------------------------------------------------------------------
class TestBoardDetails:
"""Tests for TrelloClient.board_details()."""
def test_success(self, requests_mock: Any) -> None:
"""Board details return lists and members."""
from trello_plugin.client import TrelloClient
# Resolve
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "url": "https://trello.com/b/b1"},
)
# Details fetch
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={
"id": "b1",
"name": "My Board",
"url": "https://trello.com/b/b1",
"desc": "A test board",
"closed": False,
"starred": False,
"lists": [
{"id": "l1", "name": "To Do"},
{"id": "l2", "name": "Done"},
],
"members": [
{"id": "m1", "username": "user1", "fullName": "User One"},
],
},
)
client = TrelloClient(api_key="key", token="tok")
result = client.board_details(board_id="b1")
assert result["success"] is True
assert len(result["board"]["lists"]) == 2
assert len(result["board"]["members"]) == 1
assert result["board"]["lists"][0]["name"] == "To Do"
def test_not_found(self, requests_mock: Any) -> None:
"""Non-existent board returns error."""
from trello_plugin.client import TrelloClient
requests_mock.get(
"https://api.trello.com/1/boards/nonexistent",
status_code=404,
)
requests_mock.get(
"https://api.trello.com/1/members/me/boards",
json=[],
)
client = TrelloClient(api_key="key", token="tok")
result = client.board_details(board_id="nonexistent")
assert result["success"] is False
assert "not found" in result["message"].lower()
# ---------------------------------------------------------------------------
# TrelloClient — _resolve_board_id
# ---------------------------------------------------------------------------
class TestResolveBoardId:
"""Tests for TrelloClient._resolve_board_id()."""
def test_resolves_by_id(self, requests_mock: Any) -> None:
"""Resolves a valid ID directly."""
from trello_plugin.client import TrelloClient
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "url": "https://trello.com/b/b1"},
)
client = TrelloClient(api_key="key", token="tok")
result = client._resolve_board_id("b1")
assert result["id"] == "b1"
def test_resolves_by_name(self, requests_mock: Any) -> None:
"""Resolves a board name to its ID."""
from trello_plugin.client import TrelloClient
# ID lookup fails
requests_mock.get(
"https://api.trello.com/1/boards/My%20Board",
status_code=404,
)
# List boards for name matching
requests_mock.get(
"https://api.trello.com/1/members/me/boards",
json=[
{"id": "b1", "name": "My Board", "url": "https://trello.com/b/b1", "closed": False, "starred": False},
{"id": "b2", "name": "Other Board", "url": "https://trello.com/b/b2", "closed": False, "starred": False},
],
)
client = TrelloClient(api_key="key", token="tok")
result = client._resolve_board_id("My Board")
assert result["id"] == "b1"
def test_duplicate_name_error(self, requests_mock: Any) -> None:
"""Multiple boards with same name returns error."""
from trello_plugin.client import TrelloClient
requests_mock.get(
"https://api.trello.com/1/boards/Duplicate",
status_code=404,
)
requests_mock.get(
"https://api.trello.com/1/members/me/boards",
json=[
{"id": "b1", "name": "Duplicate", "url": "", "closed": False, "starred": False},
{"id": "b2", "name": "Duplicate", "url": "", "closed": False, "starred": False},
],
)
client = TrelloClient(api_key="key", token="tok")
result = client._resolve_board_id("Duplicate")
assert "success" in result and result["success"] is False
assert "multiple" in result["message"].lower()
# ---------------------------------------------------------------------------
# Tool functions
# ---------------------------------------------------------------------------
class TestBoardToolFunctions:
"""Tests for the Hermes board management tool wrappers."""
def test_trello_create_board_tool(self, requests_mock: Any) -> None:
"""Create board tool returns valid JSON."""
from trello_plugin.tools import trello_create_board
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.post(
"https://api.trello.com/1/boards",
json={"id": "b1", "name": "New Board", "url": "https://trello.com/b/b1"},
)
result = json.loads(trello_create_board(name="New Board"))
assert result["success"] is True
assert result["board"]["name"] == "New Board"
def test_trello_rename_board_tool(self, requests_mock: Any) -> None:
"""Rename board tool returns valid JSON."""
from trello_plugin.tools import trello_rename_board
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Old", "url": ""},
)
requests_mock.put(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Renamed", "url": ""},
)
result = json.loads(trello_rename_board(board_id="b1", name="Renamed"))
assert result["success"] is True
assert result["board"]["name"] == "Renamed"
def test_trello_archive_board_tool(self, requests_mock: Any) -> None:
"""Archive board tool returns valid JSON."""
from trello_plugin.tools import trello_archive_board
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Test Board", "url": ""},
)
requests_mock.put(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Test Board", "closed": True},
)
result = json.loads(trello_archive_board(board_id="b1"))
assert result["success"] is True
assert "archived" in result["message"].lower()
def test_trello_open_board_tool(self, requests_mock: Any) -> None:
"""Open board tool returns valid JSON."""
from trello_plugin.tools import trello_open_board
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Test Board", "url": ""},
)
requests_mock.put(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Test Board", "closed": False},
)
result = json.loads(trello_open_board(board_id="b1"))
assert result["success"] is True
assert "opened" in result["message"].lower()
def test_trello_board_details_tool(self, requests_mock: Any) -> None:
"""Board details tool returns valid JSON."""
from trello_plugin.tools import trello_board_details
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Test", "url": ""},
)
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={
"id": "b1",
"name": "Test",
"url": "",
"desc": "",
"closed": False,
"starred": False,
"lists": [{"id": "l1", "name": "To Do"}],
"members": [],
},
)
result = json.loads(trello_board_details(board_id="b1"))
assert result["success"] is True
assert len(result["board"]["lists"]) == 1
-226
View File
@@ -1,226 +0,0 @@
"""Tests for the Trello plugin — list management feature."""
from __future__ import annotations
import json
import os
from typing import Any
import pytest
pytestmark = pytest.mark.usefixtures("clear_env")
# ---------------------------------------------------------------------------
# Fixtures
# ---------------------------------------------------------------------------
@pytest.fixture(autouse=True)
def clear_env(monkeypatch: pytest.MonkeyPatch) -> Any:
"""Remove Trello env vars before each test so state is predictable."""
monkeypatch.delenv("TRELLO_API_KEY", raising=False)
monkeypatch.delenv("TRELLO_TOKEN", raising=False)
# ---------------------------------------------------------------------------
# TrelloClient — create_list
# ---------------------------------------------------------------------------
class TestCreateList:
"""Tests for TrelloClient.create_list()."""
def test_success(self, requests_mock: Any) -> None:
"""Happy path: creates a list and returns details."""
from trello_plugin.client import TrelloClient
# Resolve board
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "My Board", "url": ""},
)
# Create list
requests_mock.post(
"https://api.trello.com/1/lists",
json={"id": "l1", "name": "To Do", "idBoard": "b1"},
)
client = TrelloClient(api_key="key", token="tok")
result = client.create_list(name="To Do", board_id="b1")
assert result["success"] is True
assert result["list"]["name"] == "To Do"
assert result["list"]["id_board"] == "b1"
def test_board_not_found(self, requests_mock: Any) -> None:
"""Non-existent board returns error."""
from trello_plugin.client import TrelloClient
requests_mock.get(
"https://api.trello.com/1/boards/nonexistent",
status_code=404,
)
requests_mock.get(
"https://api.trello.com/1/members/me/boards",
json=[],
)
client = TrelloClient(api_key="key", token="tok")
result = client.create_list(name="List", board_id="nonexistent")
assert result["success"] is False
assert "not found" in result["message"].lower()
def test_missing_credentials(self) -> None:
"""Missing creds returns error before any network call."""
from trello_plugin.client import TrelloClient
client = TrelloClient(api_key="", token="")
result = client.create_list(name="List", board_id="b1")
assert result["success"] is False
assert "TRELLO_API_KEY" in result["message"]
# ---------------------------------------------------------------------------
# TrelloClient — rename_list
# ---------------------------------------------------------------------------
class TestRenameList:
"""Tests for TrelloClient.rename_list()."""
def test_success(self, requests_mock: Any) -> None:
"""Renaming a list works."""
from trello_plugin.client import TrelloClient
requests_mock.put(
"https://api.trello.com/1/lists/l1",
json={"id": "l1", "name": "Renamed List"},
)
client = TrelloClient(api_key="key", token="tok")
result = client.rename_list(list_id="l1", name="Renamed List")
assert result["success"] is True
assert result["list"]["name"] == "Renamed List"
# ---------------------------------------------------------------------------
# TrelloClient — archive_list
# ---------------------------------------------------------------------------
class TestArchiveList:
"""Tests for TrelloClient.archive_list()."""
def test_success(self, requests_mock: Any) -> None:
"""Archiving a list returns success message."""
from trello_plugin.client import TrelloClient
requests_mock.put(
"https://api.trello.com/1/lists/l1",
json={"id": "l1", "name": "My List", "closed": True},
)
client = TrelloClient(api_key="key", token="tok")
result = client.archive_list(list_id="l1")
assert result["success"] is True
assert "archived" in result["message"].lower()
# ---------------------------------------------------------------------------
# TrelloClient — move_list
# ---------------------------------------------------------------------------
class TestMoveList:
"""Tests for TrelloClient.move_list()."""
def test_success(self, requests_mock: Any) -> None:
"""Moving a list returns success message."""
from trello_plugin.client import TrelloClient
requests_mock.put(
"https://api.trello.com/1/lists/l1",
json={"id": "l1", "name": "My List", "pos": 1},
)
client = TrelloClient(api_key="key", token="tok")
result = client.move_list(list_id="l1", pos="top")
assert result["success"] is True
assert "moved" in result["message"].lower()
# ---------------------------------------------------------------------------
# Tool functions
# ---------------------------------------------------------------------------
class TestListToolFunctions:
"""Tests for the Hermes list management tool wrappers."""
def test_trello_create_list_tool(self, requests_mock: Any) -> None:
"""Create list tool returns valid JSON."""
from trello_plugin.tools import trello_create_list
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.get(
"https://api.trello.com/1/boards/b1",
json={"id": "b1", "name": "Board", "url": ""},
)
requests_mock.post(
"https://api.trello.com/1/lists",
json={"id": "l1", "name": "New List", "idBoard": "b1"},
)
result = json.loads(trello_create_list(name="New List", board_id="b1"))
assert result["success"] is True
assert result["list"]["name"] == "New List"
def test_trello_rename_list_tool(self, requests_mock: Any) -> None:
"""Rename list tool returns valid JSON."""
from trello_plugin.tools import trello_rename_list
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.put(
"https://api.trello.com/1/lists/l1",
json={"id": "l1", "name": "Renamed"},
)
result = json.loads(trello_rename_list(list_id="l1", name="Renamed"))
assert result["success"] is True
assert result["list"]["name"] == "Renamed"
def test_trello_archive_list_tool(self, requests_mock: Any) -> None:
"""Archive list tool returns valid JSON."""
from trello_plugin.tools import trello_archive_list
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.put(
"https://api.trello.com/1/lists/l1",
json={"id": "l1", "name": "My List", "closed": True},
)
result = json.loads(trello_archive_list(list_id="l1"))
assert result["success"] is True
assert "archived" in result["message"].lower()
def test_trello_move_list_tool(self, requests_mock: Any) -> None:
"""Move list tool returns valid JSON."""
from trello_plugin.tools import trello_move_list
os.environ["TRELLO_API_KEY"] = "key"
os.environ["TRELLO_TOKEN"] = "tok"
requests_mock.put(
"https://api.trello.com/1/lists/l1",
json={"id": "l1", "name": "My List", "pos": 1},
)
result = json.loads(trello_move_list(list_id="l1", pos="top"))
assert result["success"] is True
assert "moved" in result["message"].lower()