From f989b144cfb9484807c11b9d2b4f9072427a6c1d Mon Sep 17 00:00:00 2001 From: crisleo94 Date: Wed, 3 Jun 2026 23:01:12 -0500 Subject: [PATCH] fix: pdf bookmark for pdfs only select pages not text --- .../components/reader/BookMarkersPanel.tsx | 10 ++- .../components/reader/BookmarkReaderRail.tsx | 4 +- .../src/components/reader/PdfReadingView.tsx | 64 ++++++++++------ frontend/src/components/reader/PdfViewer.tsx | 73 ++----------------- .../src/components/reader/ReaderToolbar.tsx | 37 +++++++++- frontend/src/hooks/usePdfHighlights.ts | 37 ---------- frontend/src/hooks/usePdfReader.ts | 3 - frontend/src/hooks/usePdfSelection.ts | 57 --------------- frontend/src/locales/en-US.ts | 7 +- frontend/src/locales/es-ES.ts | 7 +- frontend/src/reader.css | 10 ++- 11 files changed, 111 insertions(+), 198 deletions(-) delete mode 100644 frontend/src/hooks/usePdfHighlights.ts delete mode 100644 frontend/src/hooks/usePdfSelection.ts diff --git a/frontend/src/components/reader/BookMarkersPanel.tsx b/frontend/src/components/reader/BookMarkersPanel.tsx index 37bfb8f..e7252a6 100644 --- a/frontend/src/components/reader/BookMarkersPanel.tsx +++ b/frontend/src/components/reader/BookMarkersPanel.tsx @@ -12,6 +12,7 @@ interface BookMarkersPanelProps { isOpen: boolean; onClose: () => void; onGoToPassage: (marker: MarkerEntry) => void; + emptyHintKey?: string; } export function BookMarkersPanel({ @@ -19,6 +20,7 @@ export function BookMarkersPanel({ isOpen, onClose, onGoToPassage, + emptyHintKey = "annotations.selectTextHint", }: BookMarkersPanelProps) { const { t } = useTranslation(); const { markers, loadBookmarks, removeBookmark, state } = useAnnotations(); @@ -43,7 +45,7 @@ export function BookMarkersPanel({ {state.bookmarksLoading ? (

{t("annotations.loading")}

) : markers.length === 0 ? ( -

{t("annotations.selectTextHint")}

+

{t(emptyHintKey)}

) : (